[PATCH 2/2] ARM: dt: tegra: harmony: add regulators
flat view
STALE5140d
From: ldewangan@nvidia.com (Laxman Dewangan)
Date: 2012-08-28 15:04:11
Also in:
linux-tegra
On Tuesday 28 August 2012 12:40 PM, Stephen Warren wrote:
quoted hunk ↗ jump to hunk
#include "board.h" -#include "board-harmony.h" #ifdef CONFIG_TEGRA_PCI int __init harmony_pcie_init(void) { - struct regulator *regulator = NULL; + struct regulator *regulator_1v5, *regulator_pex; int err; - err = gpio_request(TEGRA_GPIO_EN_VDD_1V05_GPIO, "EN_VDD_1V05"); - if (err) - return err; + regulator_1v5 = regulator_get(NULL, "vdd_1v5"); + if (IS_ERR_OR_NULL(regulator_1v5)) { + err = PTR_ERR(regulator_1v5); + goto err_reg; + }
You need to return in case of err otherwise it will cause the crash in regulator_disable() with NULL argument.