Thread (14 messages) 14 messages, 4 authors, 2012-08-17

[PATCH-V3] ARM: OMAP3+: hwmod: Add AM33XX HWMOD data

From: tony@atomide.com (Tony Lindgren)
Date: 2012-08-17 07:49:34
Also in: linux-omap

* Hiremath, Vaibhav [off-list ref] [120815 02:11]:
On Tue, Aug 14, 2012 at 13:59:12, Tony Lindgren wrote:
quoted
Hi,

* Paul Walmsley [off-list ref] [120726 13:07]:
quoted
On Wed, 25 Jul 2012, Paul Walmsley wrote:
quoted
These IP blocks and the ECAP IP blocks have periods in their names.
The rest of the IP block named in the file don't use periods -- which
is also the style used by the rest of the OMAP SoCs.  Is there
some reason that these have periods in their names?
I've changed those to match the rest of the names, and queued the 
following for 3.7.

Thanks again for all the hard work you all put into this.  I realize that 
with all the upstream changes, this was probably a little painful for you. 
But from my perspective you've been a pleasure to work with through the 
process.
As am33xx and omap5 are DT only, we should start moving towards getting
rid of grep -E "irq|pa_start|pa_end|dma" in this patch and get the standard
data from .dtsi files instead.
It may not be so straight, given the fact that hwmod layer 
requires these resources, as hwmod is responsible to configure SYSCONF 
register of the device (happens very early at core_init level).

Somehow we have to have some mechanism to initialize " _mpu_rt_va" before 
core_init call, which will take DT resources and initialize accordingly.
That's for the device reset/idle? We should not do that in hwmod code
except in late_initcall for unclaimed devices as discussed earlier. We
discussed setting up the reset function in the device specific headers
so both device and hwmod code can call them as needed.
 
Another dependency we will have is on system timers, Jon has already done 
some initial work on this, but I believe we did not concluded on the it.
I will re-start the thread again, since in any case DT support in timer is 
required.
Right.. The timers are a pain right now as they need to be initialized
early. Everything else can and should be initialized at the device probe
time, or from a late_initcall for the unclaimed devices.
 
quoted
Alternatively we could get rid of the names and match the module based on
pa_start and pa_end.
Just FYI, from resource perspective, I have changed omap_device layer for DT 
resources only (still need hwmod resources as explained above) and patch 
looks something like (and it works) -
Cool yeah few more dependencies remain still.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help