Thread (16 messages) 16 messages, 2 authors, 2012-08-21
STALE5043d

[PATCH v2 3/4] arm/dts: Add tps65910 regulator DT data to am335x-evm.dts

From: AnilKumar, Chimata <hidden>
Date: 2012-08-16 13:25:23
Also in: linux-omap

Mark,

Small correction

On Thu, Aug 16, 2012 at 18:52:25, AnilKumar, Chimata wrote:
Mark,

On Wed, Aug 15, 2012 at 22:24:32, Mark Brown wrote:
quoted
On Wed, Aug 15, 2012 at 04:47:02PM +0000, AnilKumar, Chimata wrote:
quoted
On Wed, Aug 15, 2012 at 18:23:39, Mark Brown wrote:
quoted
quoted
If you have all these unrelated supplies in the system then your device
tree should accurately reflect that.  However this would be a very
quoted
In that case I have to add all these fixed regulators.
Why?  You then immediately go on to say...
Because all the nodes/regulators should be provided/registered otherwise
"regulator_dev_lookup" returns NULL if there are no regulator matches with
the supply_name.

I have gone through this thread
http://patchwork.ozlabs.org/patch/166682/

But problem here is single input supply battery/main is not sufficient.

pmic->desc[i].supply_name = info->vin_name;
with this assignment regulator core searches for exact supply name vcc1 or
vcc2 etc if there are no matches then it will not register any regulators. 
quoted
quoted
quoted
unusual hardware design.  Usually there would be a very small set of
system supply rails, frequently only one.
quoted
In case of AM335X-EVM one dedicated supply (5v) feeding to all the input
supplies (vcc1-7 and vccio) of the regulators.
...that they all map onto the same physical supply?
Yes single physical supply, if we want to add single fixed regulator node
to feed all the regulators then driver have to modify to support this.
Similar to revert of "regulator: tps65910: add support for input supply"
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Copy/paste error

Similar to revert of this patch "regulator: tps65910: set input_supply on
desc unconditionally"

Thanks
AnilKumar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help