Thread (7 messages) flat view 7 messages, 2 authors, 2012-08-10
STALE5106d

[PATCH 1/1] ARM: OMAP2+: hwmod: Print an error message if no match exists for a hwmod class

From: Bedia, Vaibhav <hidden>
Date: 2012-08-08 16:34:15
Also in: linux-omap

Hi Paul,

On Wed, Aug 08, 2012 at 19:35:50, Paul Walmsley wrote:
[...]
It doesn't seem to me that this would necessarily always be an error.  
Suppose some init code to create cpsw devices is running on an OMAP3430.  
Then a omap_hwmod_for_each_by_class() that doesn't locate anything 
wouldn't be an error, right?
Well, I think a failed lookup operation will be a bit expensive since it
iterates over the whole list of registered hwmods and hence put in the
pr_err(). But I don't see how the SoC specific example that you pointed out
could be handled without putting in cpu_is_* checks in the registration
process itself :(

Would a pr_debug() be ok?

Regards,
Vaibhav B.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help