Thread (15 messages) flat view 15 messages, 6 authors, 2012-08-13
STALE5128d REVIEWED: 1 (0M)

1 review trailer.

[PATCH] pinctrl: pinctrl-imx: add imx35 pinctrl driver

From: Stephen Warren <hidden>
Date: 2012-08-03 20:37:18

On 08/02/2012 09:39 AM, Uwe Kleine-K?nig wrote:
This is mostly cut'n'paste from the imx51 pinctrl driver.
quoted hunk ↗ jump to hunk
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx35-pinctrl.txt
+See below for available PIN_FUNC_ID for imx35:
+# grep '   IMX_PIN_REG' drivers/pinctrl/pinctrl-imx35.c | awk '{ print NR-1 " " $8 }'
I'd remove that line from the document; the binding doc is supposed to
be OS-agnostic, and the file drivers/pinctrl/pinctrl-imx35.c probably
only exists in Linux.
quoted hunk ↗ jump to hunk
diff --git a/drivers/pinctrl/pinctrl-imx35.c b/drivers/pinctrl/pinctrl-imx35.c
+/*
+ * imx35 pinctrl driver.
+ *
+ * This driver was mostly copied from the imx51 pinctrl driver which has:
+ *
+ * Copyright (C) 2012 Freescale Semiconductor, Inc.
+ * Copyright (C) 2012 Linaro, Inc.
+ *
+ * Author: Dong Aisheng [off-list ref]
You're not going to add your (c)? Maybe since it's mostly just data it
doesn't matter.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as published
+ * by the Free Software Foundation.
+ */
Other than that this is basically just SoC data, so I'm not really
qualified to comment:-) So,

Acked-by: Stephen Warren <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help