[PATCH v3 01/10] PCI: Keep pci_fixup_irqs() around after init
From: bhelgaas@google.com (Bjorn Helgaas)
Date: 2012-08-15 17:06:27
Also in:
linux-devicetree, linux-pci, linux-tegra
Possibly related (same subject, not in this thread)
- 2012-09-14 · Re: [PATCH v3 01/10] PCI: Keep pci_fixup_irqs() around after init · Bjorn Helgaas <hidden>
- 2012-09-14 · Re: [PATCH v3 01/10] PCI: Keep pci_fixup_irqs() around after init · Thierry Reding <hidden>
- 2012-09-07 · Re: [PATCH v3 01/10] PCI: Keep pci_fixup_irqs() around after init · Bjorn Helgaas <bhelgaas@google.com>
- 2012-09-07 · Re: [PATCH v3 01/10] PCI: Keep pci_fixup_irqs() around after init · Thierry Reding <hidden>
- 2012-09-07 · Re: [PATCH v3 01/10] PCI: Keep pci_fixup_irqs() around after init · Stephen Warren <hidden>
On Thu, Jul 26, 2012 at 12:55 PM, Thierry Reding [off-list ref] wrote:
When using deferred driver probing, PCI host controller drivers may actually require this function after the init stage. Signed-off-by: Thierry Reding <redacted> --- Changes in v3: - none Changes in v2: - use __devinit annotations
Your original patch removed __init completely. Here you change it to __devinit. That means we decide whether to discard the function based on whether CONFIG_HOTPLUG is supported. But I think your point is not about hotplug; it's merely that we should be able to scan a PCI bus after init-time. We ought to be able to do a late PCI scan even if hotplug is not supported. Therefore, I'd be inclined to remove __init completely unless you have another reason for preferring __devinit.
quoted hunk
drivers/pci/setup-irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c index eb219a1..f0bcd56 100644 --- a/drivers/pci/setup-irq.c +++ b/drivers/pci/setup-irq.c@@ -18,7 +18,7 @@ #include <linux/cache.h> -static void __init +static void __devinit pdev_fixup_irq(struct pci_dev *dev, u8 (*swizzle)(struct pci_dev *, u8 *), int (*map_irq)(const struct pci_dev *, u8, u8))@@ -54,7 +54,7 @@ pdev_fixup_irq(struct pci_dev *dev, pcibios_update_irq(dev, irq); } -void __init +void __devinit pci_fixup_irqs(u8 (*swizzle)(struct pci_dev *, u8 *), int (*map_irq)(const struct pci_dev *, u8, u8)) { --1.7.11.2