[PATCH v3 09/10] of: Add of_pci_parse_ranges()

On 08/01/2012 12:54 AM, Thierry Reding wrote:

On Tue, Jul 31, 2012 at 03:07:31PM -0500, Rob Herring wrote:

quoted

On 07/26/2012 02:55 PM, Thierry Reding wrote:

quoted

This new function parses the ranges property of PCI device
nodes into an array of struct resource elements. It is useful
in multiple-port PCI host controller drivers to collect
information about the ranges that it needs to forward to the
respective ports.

It seems to me that some of the DT PCI code in
arch/powerpc/kernel/pci* like pci_process_bridge_OF_ranges()
should apply for ARM as well.

Each arch defining their own pci controller structs complicates
this, but I would think at least the DT parsing can be common.

Yes, there's quite a lot of room for refactoring. When I first
started work on this there had been some discussion about whether
it would make sense to move PCI controller drivers into a common
location to make it easier to refactor but the consensus at the
time was that this should not be done.

In the long term, if we end up with a separate arch/aarch64/, I think
we'll have to move the PCIe (and any other) drivers to a common
location. Still, I imagine there is plenty of time until that's mandatory.