[PATCH] hvc_dcc : add support to armv4 and armv5 core

On Fri, Aug 31, 2012 at 11:59:39AM +0100, Alan Cox wrote:

On Fri, 31 Aug 2012 11:33:51 +0100
Russell King - ARM Linux [off-list ref] wrote:

quoted

On Fri, Aug 31, 2012 at 12:29:04PM +0200, Matthieu CASTET wrote:

quoted

Alan Cox a ?crit :

quoted

On Fri, 31 Aug 2012 11:21:56 +0200
Matthieu CASTET [off-list ref] wrote:

quoted

Signed-off-by: Matthieu Castet <redacted>
---
 drivers/tty/hvc/hvc_dcc.c |   34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

This is a step in the wrong direction. This should all be runtime handled

NAK.

AFAIK you can't build a arm kernel that support arm6/armv7 and armv5.
And I am not sure it will be possible one day.

There are no plans to ever make it possible; there are too many significant
differences between ARMv4, v5 architectures and ARMv6,v7 architectures
to warrant making this runtime selectable.

Then bury this crap in platform files please not in the drivers/tty layer
code. Make it a platform driver provided callback or something.

Platform driver callbacks via platform data are incompatible with DT,
which is where folk elsewhere in the kernel community have kicked ARM
towards, away from the platform driver/device with platform data model.