[PATCH] usb: tegra: moving phy driver into drivers directory
From: Stephen Warren <hidden>
Date: 2012-08-28 14:07:34
Also in:
linux-tegra, lkml
On 08/28/2012 02:32 AM, Venu Byravarasu wrote:
In order to keep up with the USB driver files organization, moving USB phy driver from mach-tegra to drivers/USB directory. Signed-off-by: Venu Byravarasu <redacted>
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/mach-tegra/devices.c b/arch/arm/mach-tegra/devices.c
quoted hunk ↗ jump to hunk
-struct tegra_ulpi_config tegra_ehci2_ulpi_phy_config = { - .reset_gpio = -1, - .clk = "cdev2", -}; - struct tegra_ehci_platform_data tegra_ehci1_pdata = { .operating_mode = TEGRA_USB_OTG, .power_down_on_bus_suspend = 1,@@ -450,7 +444,7 @@ struct tegra_ehci_platform_data tegra_ehci1_pdata = { }; struct tegra_ehci_platform_data tegra_ehci2_pdata = { - .phy_config = &tegra_ehci2_ulpi_phy_config, + .phy_config = NULL,
The PHY driver checks that field isn't NULL, and fails if it is:
struct tegra_usb_phy *tegra_usb_phy_open(struct device *dev, int instance,
void __iomem *regs, void *config, enum tegra_usb_phy_mode phy_mode)
{...
phy->config = config;
phy->mode = phy_mode;
if (!phy->config) {
if (phy_is_ulpi(phy)) {
pr_err("%s: ulpi phy configuration missing", __func__);
err = -EINVAL;
goto err0;So, this change will completely break ULPI support, which currently works fine. So, NAK. I also plan on deleting devices.[ch] in kernel 3.7, and moving the USB platform data into board-dt-tegra20.c, since that's the only place it's used right now. So, this patch would conflict with that rather badly. I just posted the patches for that to the linux-tegra mailing list last night. Do you have better proposals for that? Perhaps usb_phy.c should set phy->config to &ulpi_default in a similar fashion to how it works for UTMI; that would remove some of the coupling between the changes. BTW, in your response to Felipe, you said...
Thanks Felipe for your comments. Created a patch to separate out phy related stuff to phy.h with you as a reviewer. Plz let me know your comments.
... where is that patch?