[PATCH 14/14] drivers/spi/spi-s3c24xx.c: fix error return code
From: Kukjin Kim <hidden>
Date: 2012-08-22 09:38:41
Also in:
kernel-janitors, linux-samsung-soc, linux-spi, lkml
Julia Lawall wrote:
From: Julia Lawall <redacted> Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if at p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret at p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <redacted>
Acked-by: Kukjin Kim <redacted> (Cc'ed Mark Brown who is handling spi for a moment)
--- Perhaps -EINVAL is not the right value in this case.
Well, if (pin_cs < 0) is true, it is really invalid value. So I think, it makes sense :-) Thanks. Best regards, Kgene. -- Kukjin Kim [off-list ref], Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
quoted hunk ↗ jump to hunk
drivers/spi/spi-s3c24xx.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c index 8ee7d79..a2a080b 100644 --- a/drivers/spi/spi-s3c24xx.c +++ b/drivers/spi/spi-s3c24xx.c@@ -611,6 +611,7 @@ static int __devinit s3c24xx_spi_probe(structplatform_device *pdev) if (!pdata->set_cs) { if (pdata->pin_cs < 0) { dev_err(&pdev->dev, "No chipselect pin\n"); + err = -EINVAL; goto err_register; }