[PATCH 2/6] mfd: Provide the PRCMU with its own IRQ domain
flat view
From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-08-06 11:51:00
Also in:
lkml
On Monday 06 August 2012, Lee Jones wrote:
+struct irq_domain *db8500_irq_domain; +
Should this be static?
quoted hunk ↗ jump to hunk
@@ -2583,7 +2585,7 @@ static void prcmu_irq_mask(struct irq_data *d) spin_lock_irqsave(&mb0_transfer.dbb_irqs_lock, flags); - mb0_transfer.req.dbb_irqs &= ~prcmu_irq_bit[d->irq - IRQ_PRCMU_BASE]; + mb0_transfer.req.dbb_irqs &= ~prcmu_irq_bit[d->hwirq]; spin_unlock_irqrestore(&mb0_transfer.dbb_irqs_lock, flags);
Ah, so the hwirq number *is* used directly here, unlike what I thought when we first discussed it. I suppose that means we don't need the xlate function after all (and you did not add one). Arnd