From: Fabio Estevam <redacted>
Include IMX6 in the list of supported SoCs.
Signed-off-by: Fabio Estevam <redacted>
---
Changes since v1:
- No changes
drivers/mtd/nand/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
From: Fabio Estevam <redacted>
MTD_NAND_GPMI_NAND driver depends on MXS_DMA to be selected, otherwise the following error happens
for imx_v6_v7_defconfig:
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1
Signed-off-by: Fabio Estevam <redacted>
---
Changes since v1:
- Use 'depends' rather than 'select'
drivers/mtd/nand/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
From: Fabio Estevam <redacted>
Let MXS_DMA be selected by default.
Signed-off-by: Fabio Estevam <redacted>
---
Changes since v1:
- No changes. Newly introduced in this series
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
@@ -192,6 +192,7 @@ CONFIG_RTC_DRV_MC13XXX=y CONFIG_RTC_DRV_MXC=y CONFIG_DMADEVICES=y CONFIG_IMX_SDMA=y+CONFIG_MXS_DMA=y CONFIG_COMMON_CLK_DEBUG=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_EXT2_FS=y
Hi Fabio:
On Wed, Jul 25, 2012 at 7:18 AM, Fabio Estevam [off-list ref] wrote:
quoted hunk
From: Fabio Estevam <redacted>
Let MXS_DMA be selected by default.
Signed-off-by: Fabio Estevam <redacted>
---
Changes since v1:
- No changes. Newly introduced in this series
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q.
this patch makes the kernel built-in the mxs-dma, even the gpmi-nand
is not enabled.
Huang Shijie
CONFIG_COMMON_CLK_DEBUG=y
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_EXT2_FS=y
--
1.7.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Wed, Jul 25, 2012 at 12:05 PM, Huang Shijie [off-list ref] wrote:
Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q.
this patch makes the kernel built-in the mxs-dma, even the gpmi-nand
is not enabled.
Well, as the driver currently stands: yes, it is needed.
Without CONFIG_MXS_DMA, the GPMI driver cannot even be built.
This is why I thought that 'select MXS_DMA' was the way to go, but
according to the thread you pointed me at, it was Nacked by Shawn.
Regards,
Fabio Estevam
On Wed, Jul 25, 2012 at 11:23 PM, Fabio Estevam [off-list ref] wrote:
On Wed, Jul 25, 2012 at 12:05 PM, Huang Shijie [off-list ref] wrote:
quoted
Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q.
this patch makes the kernel built-in the mxs-dma, even the gpmi-nand
is not enabled.
Well, as the driver currently stands: yes, it is needed.
Without CONFIG_MXS_DMA, the GPMI driver cannot even be built.
But you have added "depend on MXS_DMA". So If you do not select the
mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
Huang Shijie
This is why I thought that 'select MXS_DMA' was the way to go, but
according to the thread you pointed me at, it was Nacked by Shawn.
Regards,
Fabio Estevam
I think we can merget the patch 1 and patch 2 to one patch.
Huang Shijie
On Wed, Jul 25, 2012 at 7:18 PM, Fabio Estevam [off-list ref] wrote:
quoted hunk
From: Fabio Estevam <redacted>
MTD_NAND_GPMI_NAND driver depends on MXS_DMA to be selected, otherwise the following error happens
for imx_v6_v7_defconfig:
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1
Signed-off-by: Fabio Estevam <redacted>
---
Changes since v1:
- Use 'depends' rather than 'select'
drivers/mtd/nand/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
On Thu, Jul 26, 2012 at 10:24:41AM +0800, Huang Shijie wrote:
On Wed, Jul 25, 2012 at 11:23 PM, Fabio Estevam [off-list ref] wrote:
quoted
On Wed, Jul 25, 2012 at 12:05 PM, Huang Shijie [off-list ref] wrote:
quoted
Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q.
this patch makes the kernel built-in the mxs-dma, even the gpmi-nand
is not enabled.
Well, as the driver currently stands: yes, it is needed.
Without CONFIG_MXS_DMA, the GPMI driver cannot even be built.
But you have added "depend on MXS_DMA". So If you do not select the
mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
On Wed, Jul 25, 2012 at 11:27 PM, Huang Shijie [off-list ref] wrote:
I think we can merget the patch 1 and patch 2 to one patch.
I am not sure on this, as they have clearly different purposes.
Patch 1 fixes the text file and include mx6.
Patch 2 fixes a build issue for mx6.
I prefer to keep them as seperate patches.
Regards,
Fabio Estevam
On Thu, 2012-07-26 at 10:24 +0800, Huang Shijie wrote:
But you have added "depend on MXS_DMA". So If you do not select the
mxs-dma, you can not see the gpmi-nand.
That's an issue with the 'make *config' tools. I recommend fixing those
instead; it's horrid to use 'select' on an option which *is*
user-visible, such as CONFIG_MXS_DMA.
In the mid-1990s, there was a variant of the tcl 'make xconfig' which
would *show* you the dependencies for things, and would allow you to
turn them on with a single click. Is that really so hard for us to do?
--
dwmw2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6171 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120726/07b8ffc0/attachment.bin>
On Wed, Jul 25, 2012 at 11:24 PM, Huang Shijie [off-list ref] wrote:
But you have added "depend on MXS_DMA". So If you do not select the
mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
So how CONFIG_MXS_DMA would be selected if not via defconfig?
On Thu, Jul 26, 2012 at 6:53 AM, Fabio Estevam [off-list ref] wrote:
On Wed, Jul 25, 2012 at 11:24 PM, Huang Shijie [off-list ref] wrote:
quoted
But you have added "depend on MXS_DMA". So If you do not select the
mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
So how CONFIG_MXS_DMA would be selected if not via defconfig?
Use the make menuconfig ARCH=arm:
"device drivers"-->"DMA engine support" -->"mxs dma support"
Huang Shijie
On Thu, Jul 26, 2012 at 7:56 AM, Huang Shijie [off-list ref] wrote:
On Thu, Jul 26, 2012 at 6:53 AM, Fabio Estevam [off-list ref] wrote:
quoted
On Wed, Jul 25, 2012 at 11:24 PM, Huang Shijie [off-list ref] wrote:
quoted
But you have added "depend on MXS_DMA". So If you do not select the
mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
So how CONFIG_MXS_DMA would be selected if not via defconfig?
Use the make menuconfig ARCH=arm:
"device drivers"-->"DMA engine support" -->"mxs dma support"
I prefer to have selected in the defconfig by default instead.
It is not obvious for the end user that they need to manually select
this option.
mxs_defconfig also selects CONFIG_MXS_DMA.
Can't we do the same here and let imx_v6_v7_defconfig be built again?
On Thu, Jul 26, 2012 at 7:08 AM, Fabio Estevam [off-list ref] wrote:
On Thu, Jul 26, 2012 at 7:56 AM, Huang Shijie [off-list ref] wrote:
quoted
On Thu, Jul 26, 2012 at 6:53 AM, Fabio Estevam [off-list ref] wrote:
quoted
On Wed, Jul 25, 2012 at 11:24 PM, Huang Shijie [off-list ref] wrote:
quoted
But you have added "depend on MXS_DMA". So If you do not select the
mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
So how CONFIG_MXS_DMA would be selected if not via defconfig?
Use the make menuconfig ARCH=arm:
"device drivers"-->"DMA engine support" -->"mxs dma support"
I prefer to have selected in the defconfig by default instead.
It is not obvious for the end user that they need to manually select
this option.
mxs_defconfig also selects CONFIG_MXS_DMA.
In mx23/mx28, the mxs-dma has many users, so it's proper to make it default.
Can't we do the same here and let imx_v6_v7_defconfig be built again?
Shawn, do you have any opinion about this?
Huang Shijie
From: Richard Zhao <hidden> Date: 2012-07-27 09:26:13
On Thu, Jul 26, 2012 at 07:32:54AM -0400, Huang Shijie wrote:
On Thu, Jul 26, 2012 at 7:08 AM, Fabio Estevam [off-list ref] wrote:
quoted
On Thu, Jul 26, 2012 at 7:56 AM, Huang Shijie [off-list ref] wrote:
quoted
On Thu, Jul 26, 2012 at 6:53 AM, Fabio Estevam [off-list ref] wrote:
quoted
On Wed, Jul 25, 2012 at 11:24 PM, Huang Shijie [off-list ref] wrote:
quoted
But you have added "depend on MXS_DMA". So If you do not select the
mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
So how CONFIG_MXS_DMA would be selected if not via defconfig?
Use the make menuconfig ARCH=arm:
"device drivers"-->"DMA engine support" -->"mxs dma support"
I prefer to have selected in the defconfig by default instead.
It is not obvious for the end user that they need to manually select
this option.
mxs_defconfig also selects CONFIG_MXS_DMA.
In mx23/mx28, the mxs-dma has many users, so it's proper to make it default.
quoted
Can't we do the same here and let imx_v6_v7_defconfig be built again?
Shawn, do you have any opinion about this?
Most drivers should be kernel modules. mxs_dma needs changes to support
building as module.
Thanks
Richard
From: Richard Zhao <hidden> Date: 2012-07-27 09:28:20
On Wed, Jul 25, 2012 at 08:18:19AM -0300, Fabio Estevam wrote:
From: Fabio Estevam <redacted>
MTD_NAND_GPMI_NAND driver depends on MXS_DMA to be selected, otherwise the following error happens
for imx_v6_v7_defconfig:
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1
Signed-off-by: Fabio Estevam <redacted>
Reviewed-by: Richard Zhao <redacted>
quoted hunk
---
Changes since v1:
- Use 'depends' rather than 'select'
drivers/mtd/nand/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
--
1.7.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Richard Zhao <hidden> Date: 2012-07-27 09:30:00
On Wed, Jul 25, 2012 at 08:18:18AM -0300, Fabio Estevam wrote:
quoted hunk
From: Fabio Estevam <redacted>
Include IMX6 in the list of supported SoCs.
Signed-off-by: Fabio Estevam <redacted>
---
Changes since v1:
- No changes
drivers/mtd/nand/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
We don't need to list all SoCs. Shall we just check MXC or MXS ?
Thanks
Richard
help
- Enables NAND Flash support for IMX23 or IMX28.
+ Enables NAND Flash support for IMX23, IMX28 or IMX6.
The GPMI controller is very powerful, with the help of BCH
module, it can do the hardware ECC. The GPMI supports several
NAND flashs at the same time. The GPMI may conflicts with other
--
1.7.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Jul 26, 2012 at 7:08 AM, Fabio Estevam [off-list ref] wrote:
quoted
On Thu, Jul 26, 2012 at 7:56 AM, Huang Shijie [off-list ref] wrote:
quoted
On Thu, Jul 26, 2012 at 6:53 AM, Fabio Estevam [off-list ref] wrote:
quoted
On Wed, Jul 25, 2012 at 11:24 PM, Huang Shijie [off-list ref] wrote:
quoted
But you have added "depend on MXS_DMA". So If you do not select the
mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
So how CONFIG_MXS_DMA would be selected if not via defconfig?
Use the make menuconfig ARCH=arm:
"device drivers"-->"DMA engine support" -->"mxs dma support"
I prefer to have selected in the defconfig by default instead.
It is not obvious for the end user that they need to manually select
this option.
mxs_defconfig also selects CONFIG_MXS_DMA.
In mx23/mx28, the mxs-dma has many users, so it's proper to make it default.
quoted
Can't we do the same here and let imx_v6_v7_defconfig be built again?
Shawn, do you have any opinion about this?
First, I think Shawn is on holiday at the moment.
Second, recent kernel mainline from today building imx_v6_v7_defconfig
is broken due to this.
So to make it build again, we have to enable CONFIG_MXS_DMA anyhow. As
it seems that GPMI_NAND needs it to build, I would vote for the
depends on MXS_DMA
fix proposed by Richard
http://www.spinics.net/lists/arm-kernel/msg186111.html
Anyhow, any chance to get the kernel mainline fixed asap?
Many thanks and best regards
Dirk
We don't need to list all SoCs. Shall we just check MXC or MXS ?
The gpmi nand controller only exits in mx23/mx23/mx50/mx6q. In
mx53/mx35, we use the mxc-nand controller.
So it's better to list all the supported SoCs here.
Best Regards
Huang Shijie
On Thu, Jul 26, 2012 at 7:08 AM, Fabio Estevam [off-list ref]
wrote:
quoted
On Thu, Jul 26, 2012 at 7:56 AM, Huang Shijie [off-list ref]
wrote:
quoted
On Thu, Jul 26, 2012 at 6:53 AM, Fabio Estevam [off-list ref]
wrote:
quoted
On Wed, Jul 25, 2012 at 11:24 PM, Huang Shijie [off-list ref]
wrote:
quoted
But you have added "depend on MXS_DMA". So If you do not select the
mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
So how CONFIG_MXS_DMA would be selected if not via defconfig?
Use the make menuconfig ARCH=arm:
"device drivers"-->"DMA engine support" -->"mxs dma support"
I prefer to have selected in the defconfig by default instead.
It is not obvious for the end user that they need to manually select
this option.
mxs_defconfig also selects CONFIG_MXS_DMA.
In mx23/mx28, the mxs-dma has many users, so it's proper to make it
default.
quoted
Can't we do the same here and let imx_v6_v7_defconfig be built again?
Shawn, do you have any opinion about this?
First, I think Shawn is on holiday at the moment.
Second, recent kernel mainline from today building imx_v6_v7_defconfig
is broken due to this.
Sascha did not CC to me when he submitted the patch 3def84ed9 "ARM:
imx_v6_v7_defconfig: ..".
I would check this patch if he CCed to me.
BR
Huang Shijie
So to make it build again, we have to enable CONFIG_MXS_DMA anyhow. As
it seems that GPMI_NAND needs it to build, I would vote for the
depends on MXS_DMA
fix proposed by Richard
http://www.spinics.net/lists/arm-kernel/msg186111.html
Anyhow, any chance to get the kernel mainline fixed asap?
Many thanks and best regards
Dirk
On Thu, Jul 26, 2012 at 07:38:57AM -0300, Fabio Estevam wrote:
On Wed, Jul 25, 2012 at 11:29 PM, Dong Aisheng [off-list ref] wrote:
quoted
How about using 'select MXS_DMA'?
Ok, I prefer this way too. Will resubmit it soon. Hopefully it is OK with Shawn.
No. For your information, the following is what
Documentation/kbuild/kconfig-language.txt tell.
Note:
select should be used with care. select will force
a symbol to a value without visiting the dependencies.
By abusing select you are able to select a symbol FOO even
if FOO depends on BAR that is not set.
In general use select only for non-visible symbols
(no prompts anywhere) and for symbols with no dependencies.
That will limit the usefulness but on the other hand avoid
the illegal configurations all over.
--
Regards,
Shawn
From: Fabio Estevam <redacted>
Let MXS_DMA be selected by default.
Signed-off-by: Fabio Estevam <redacted>
---
Changes since v1:
- No changes. Newly introduced in this series
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
@@ -192,6 +192,7 @@ CONFIG_RTC_DRV_MC13XXX=y CONFIG_RTC_DRV_MXC=y CONFIG_DMADEVICES=y CONFIG_IMX_SDMA=y+CONFIG_MXS_DMA=y CONFIG_COMMON_CLK_DEBUG=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_EXT2_FS=y
Building mainline 3.6-rc1 with imx_v6_v7_defconfig this is still broken
due to
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xab170): undefined reference to `mxs_dma_is_apbh'
Is any fix for this on its way to mainline? Either the above or any
other one?
Best regards
Dirk
From: Fabio Estevam <redacted>
Let MXS_DMA be selected by default.
Signed-off-by: Fabio Estevam <redacted>
---
Changes since v1:
- No changes. Newly introduced in this series
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig
b/arch/arm/configs/imx_v6_v7_defconfig
index f725b96..3c9f32f 100644
CONFIG_RTC_DRV_MXC=y
CONFIG_DMADEVICES=y
CONFIG_IMX_SDMA=y
+CONFIG_MXS_DMA=y
CONFIG_COMMON_CLK_DEBUG=y
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_EXT2_FS=y
Building mainline 3.6-rc1 with imx_v6_v7_defconfig this is still
broken due to
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xab170): undefined reference to
`mxs_dma_is_apbh'
Is any fix for this on its way to mainline? Either the above or any
other one?
Best regards
Dirk
Since the gpmi has been enabled in the config file, I think it's better
to select the mxs-dma in the config file too.
Acked-by: Huang Shijie <redacted>
Huang Shijie
On Wed, Jul 25, 2012 at 08:18:19AM -0300, Fabio Estevam wrote:
From: Fabio Estevam <redacted>
MTD_NAND_GPMI_NAND driver depends on MXS_DMA to be selected, otherwise the following error happens
for imx_v6_v7_defconfig:
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1
Signed-off-by: Fabio Estevam <redacted>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
As mentioned elsewhere in this thread: We should not select user visible
options, so this patch is the only thing we can do atm (apart from
'fixing the tools' as David mentioned, but this is out of scope for an
-rc kernel)
Additionally the imx_v6_v7_defconfig should be adjusted so that the gpmi
nand driver actually gets built.
Sascha
quoted hunk
---
Changes since v1:
- Use 'depends' rather than 'select'
drivers/mtd/nand/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
On Wed, Jul 25, 2012 at 08:18:19AM -0300, Fabio Estevam wrote:
quoted
From: Fabio Estevam<redacted>
MTD_NAND_GPMI_NAND driver depends on MXS_DMA to be selected, otherwise the following error happens
for imx_v6_v7_defconfig:
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1
Signed-off-by: Fabio Estevam<redacted>
Acked-by: Sascha Hauer<s.hauer@pengutronix.de>
As mentioned elsewhere in this thread: We should not select user visible
options, so this patch is the only thing we can do atm (apart from
'fixing the tools' as David mentioned, but this is out of scope for an
-rc kernel)
I asked Shawn about this and it seems that this patch is the way to go
for the moment. So:
Acked-by: Dirk Behme <redacted>
David: Artem: Building recent 3.6-rc1mainline with imx_v6_v7_defconfig
is broken. We need this patch to get it working, again.
It would be nice if this patch could go as a fix into 3.6-rcX mainline
asap. Could you help with this?
Many thanks and best regards
Dirk
Additionally the imx_v6_v7_defconfig should be adjusted so that the gpmi
nand driver actually gets built.
Sascha
quoted
---
Changes since v1:
- Use 'depends' rather than 'select'
drivers/mtd/nand/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)