On Mon, Jul 23, 2012 at 07:13:52PM +0800, Richard Zhao wrote:

On Mon, Jul 23, 2012 at 01:51:55PM +0300, Felipe Balbi wrote:

quoted

On Mon, Jul 23, 2012 at 11:30:18AM +0200, Marc Kleine-Budde wrote:

quoted

On 07/23/2012 11:27 AM, Richard Zhao wrote:

quoted

quoted

This patch looks like a recipe for disaster IMHO, but it's Alex's call.

Well, if there's any better place to hold it, I'd like to move there.
Another place is arch/arm/mach-imx. Sascha/Shawn who are maintainers of
imx are also in cc list.

IMHO it's not about the place where the driver is located, it's about
the shortcomings Michael and Sascha mentioned.

Thanks, Marc.

quoted

exactly. It's not about where a file is placed or how it's called. It's
how you decided to implement it. This will prevent a platform with
multiple instances of the IP to be used, at least.

To me, usbmisc on imx6 is just a set of non-core registers which is
companion of Chipidea IP cores. All cores share the same usbmisc.
From design perspective, ci13xxx_imx knows nothing about usbmisc. It
just call the ops in proper occasion. usbmisc driver wrappers all
SoC specific things.

but if all you need is to call and initialization function, why don't
you just do it on probe() of that usbmisc stuff ? Is this usbmisc used
only for this USB IP ?

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120723/32922d8b/attachment.sig>