[RFC PATCH 3/4] ARM: arch_timers: give the virtual timer its own interrupt handler
From: Christopher Covington <hidden>
Date: 2012-07-17 16:57:54
Hi Marc, On 07/06/2012 05:20 AM, Marc Zyngier wrote:
quoted hunk ↗ jump to hunk
In order to prepare for the timer interrupt offloading to the hypervisor, give the virtual timer its own interrupt handler. Signed-off-by: Marc Zyngier <redacted> --- arch/arm/kernel/arch_timer.c | 8 ++++++++ 1 file changed, 8 insertions(+)diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c index 2b5da66..4473f66 100644 --- a/arch/arm/kernel/arch_timer.c +++ b/arch/arm/kernel/arch_timer.c
[...]
quoted hunk ↗ jump to hunk
@@ -408,6 +413,9 @@ static int __init arch_timer_register(void) if (!arch_timer_ppi[i]) continue; + if (i == VIRT_PPI) + handler = arch_timer_virt_handler; +
Again, it seems awkward to do this sort of thing inside the loop as you're only keying off of one value with a known index in the array.
err = request_percpu_irq(arch_timer_ppi[i], handler,
"arch_timer", arch_timer_evt);
if (err) {Regards, Christopher -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum