Thread (17 messages) flat view 17 messages, 2 authors, 2012-07-17
STALE5168d

[RFC PATCH 05/12] ARM: Add DT support to decompressor tags

From: Domenico Andreoli <hidden>
Date: 2012-07-17 14:41:09

On Tue, Jul 17, 2012 at 02:14:19PM +0000, Arnd Bergmann wrote:
On Sunday 15 July 2012, Domenico Andreoli wrote:
quoted
-ifeq ($(CONFIG_ARM_ATAG_DTB_COMPAT),y)
 OBJS   += $(libfdt_objs) atags_to_fdt.o
-endif
Can you explain why this is necessary? I don't see any code
of that file being called from the newly added code for the
case where CONFIG_ARM_ATAG_DTB_COMPAT is disabled.
I put function get_fdt_prop() in atags_to_fdt.c but what I basically needed
was the inclusion of $(libfdt_objs). I agree this can be achieved out of
CONFIG_ARM_ATAG_DTB_COMPAT's stuff and I'll do if the patchest is allowed
to mature.

I guess a better place could be libfdt itself but feel free to suggest a
better one.

Thanks,
Domenico
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help