[PATCH 3/3] ARM: convert asm/irqflags.h to use asm-generic/irqflags.h

On 07/16/2012 01:35 AM, Hui Wang wrote:

Rob Herring wrote:

quoted

From: Rob Herring <redacted>

By implmenting arch_local_irq_restore with constant flags, we can use
asm-generic/irqflags.h and remove some of the ARM version of irqflags.h.

  

[...]

quoted

-        : "r" (flags)
-        : "memory", "cc");
-}
-
 static inline int arch_irqs_disabled_flags(unsigned long flags)
 {
     return flags & PSR_I_BIT;
 }
+#define arch_irqs_disabled_flags arch_irqs_disabled_flags
+
  

Why don't directly define arch_irqs_disabled_flags like that:

#define arch_irqs_disabled_flags(flags) (flags & PSR_I_BIT)

In most cases, I think inlines are preferred as they have type checking.
Doesn't really matter to me.

Rob

quoted

+#include <asm-generic/irqflags.h>
 
 #endif
 #endif