Thread (7 messages) flat view 7 messages, 4 authors, 2012-07-09
DORMANTno replies

[PATCH] ARM: PRIMA2: convert to common clk and finish full clk tree

From: Turquette, Mike <hidden>
Date: 2012-07-09 18:00:08

On Sun, Jul 8, 2012 at 12:26 AM, Barry Song [off-list ref] wrote:
Hi Mike,

2012/7/7 Arnd Bergmann [off-list ref]:
quoted
On Saturday 07 July 2012, Mike Turquette wrote:
quoted
I don't mind dropping your patches from clk-next and taking new ones.
Go ahead and send me a new patch which does everything instead of an
incremental patch to simply 'git mv' the code. ?Feel free to split the
patch up if needed.
FWIW, I would always recommend doing this in two patches, one that changes
the code and one that moves the file, in either order. The main difference
is that for those who cannot use 'git diff -M', reviewing the patch becomes
much easier when it doesn't look like one file is removed and another
completely different file is added.
i tend towards the latter one. i am thinking those might be two jobs:
1. change the current drivers to common clk and finish the whole tree
2. move the updated driver to the right place after 1

so they might be two patches, how do you think?
Sounds good.  Arnd is correct that performing the 'git mv' in
isolation from the other change is the best practice.

Regards,
Mike
quoted
? ? ? ? Arnd
-barry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help