Thread (5 messages) flat view 5 messages, 5 authors, 2012-07-05
STALE5182d REVIEWED: 2 (0M)

2 review trailers.

[PATCH] regulator: core: remove sysfs entry properly in regulator_put

From: Dong Aisheng <hidden>
Date: 2012-07-05 08:28:46

On Thu, Jul 05, 2012 at 02:19:42PM +0800, Shawn Guo wrote:
With changes introduced by commit 222cc7b (regulator: core: Allow
multiple requests of a single supply mapping) on create_regulator,
regulator_put needs a corresponding update on sysfs entry removing.

Also regulator->dev still needs to get assigned in create_regulator,
otherwise, sysfs_remove_link call in regulator_put will get bypassed.

Reported-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Shawn Guo <redacted>
---
 drivers/regulator/core.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
Good catch.

Tested-by: Dong Aisheng <redacted>
Acked-by: Dong Aisheng <redacted>

Regards
Dong Aisheng
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help