[PATCH v2 07/12] I2C: MV64XXX: Add Device Tree support

On Wed, Jul 04, 2012 at 09:49:33PM +0200, Florian Fainelli wrote:

Hello Andrew,

On Tuesday 03 July 2012 18:58:39 Andrew Lunn wrote:

quoted

On Tue, Jul 03, 2012 at 05:59:13PM +0200, Florian Fainelli wrote:

quoted

Hello Andrew,

On Tuesday 03 July 2012 16:22:40 Andrew Lunn wrote:

quoted

Extends the driver to get properties from device tree. Also extend the
kirkwood DT support to supply the needed properties.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---

[snip]

quoted

-	if ((pd->id != 0) || !pdata)
+	if ((!pdata && !pd->dev.of_node) || (pdata && (pd->id != 0)))
 		return -ENODEV;

This is more a reminder than a real remark, but the driver here should not 

be 

quoted

quoted

limiting us to a single platform_device. In fact kirkwood55 (88F6282) has 

two 

quoted

quoted

I2C controllers for instance.

Yes, i don't understand this code. It looks impossible to use it using
platform_data with more than one controller. Any idea why its like
this? I didn't want to change the behavior because i don't understand
why its like this.

No idea, we just stumbled over this with a colleague the other day, and just 
removing the check made our second I2C controller work, so I don't see any 
reason why there is such a limitation. That said, this is for a subsequent 
patch.

If you submit a patch, please CC: me and i will ACK it, or test it
etc, and try to sort out the merge conflicts with the DT patch.

	Thanks
		Andrew