[PATCH v2 08/12] Kirkwood: Add basic device tree support for QNAP TS219.

On Tue, Jul 03, 2012 at 05:47:57PM +0200, Florian Fainelli wrote:

Hi Andrew,

On Tuesday 03 July 2012 16:22:41 Andrew Lunn wrote:

quoted

The two different variants of QNAP TS devices, varying by SoC, put the
GPIO keys on different GPIO lines. Hence we need two different DT
board descriptions, which share the same board-ts219.c file.

Why don't you reorder this patch to be after patch 11/12 so that you do not 
need to update this file in patch 11/12?

It just reflects the order i did the work. I can rebase it, but what
is the advantage? It should be fully bisectable as is.

quoted

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Jason Cooper <redacted>
---

[snip]

quoted

 
+config MACH_TS219_DT
+	bool "Device Tree for QNAP TS-110, TS-119, TS-119P+, TS-210, TS-219, 

TS-219P and TS-219P+ Turbo NAS"

This looks too long, how about just "Device Tree for QNAP TS-11x, TS-21x NAS" 
for instance?

Yes, i was not too happy with this. I copied the none DT version as a
basis, since that is what kernel builds know at the moment. Since i'm
not alone not liking it, i will change it as you suggested.

    Thanks
	Andrew