Thread (10 messages) flat view 10 messages, 2 authors, 2012-07-31

[PATCH 1/5] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

From: Mark Brown <hidden>
Date: 2012-07-31 14:56:18
Also in: alsa-devel, lkml

On Tue, Jul 31, 2012 at 03:45:40PM +0100, Lee Jones wrote:
If a list of widgets is provided and one of them fails to be added as
a control, the present semantics fail all subsequent widgets. A better
solution would be to only fail that widget, but pursue in attempting
to add the rest of the list.
To reiterate, this is in *no* way urgent or even a bug fix.
 			dev_err(dapm->dev,
 				"ASoC: Failed to create DAPM control %s\n",
 				widget->name);
-			ret = -ENOMEM;
-			break;
Indeed, removing the error return is a regression.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help