[PATCH 3/9] ARM: ux500: Remove AB8500 regulator register initialisation information
From: Lee Jones <hidden>
Date: 2012-07-06 07:45:43
Also in:
lkml
On 06/07/12 07:55, Linus Walleij wrote:
On Thu, Jul 5, 2012 at 3:06 PM, Lee Jones [off-list ref] wrote:quoted
There is no need to initialise the AB8500's regulator registers, as most of this work is already carried out by framework features, so we can safely remove all traces from platform code. Signed-off-by: Lee Jones <redacted>NACK, sorry. These registers are used to set up sleep states for the regulators, e.g that some regulators will turn off when the system go to sleep. If you delete this code it's no longer possible to make the system powerefficient, power consumption increases so it causes a regression. The proper thing to do is to take the AB8500 datasheet, go in and read what these registers actually do, and provide the same features through the framework, if just poking the registers is deemed non-elegant (I see the point in that). This is the AB8500 datasheet: http://www.stericsson.com/developers/CD00291561_UM1031_AB8500_user_manual-rev5_CTDS_public.pdf So please refactor this, don't just delete, that's destroying a lot of useful stuff.
Sounds reasonable. I won't be doing the refactoring, as I'm moving onto something else from Monday. Unless of course I find myself with lots of spare time *chuckles*. Mark, Please take a note of this and also do not apply the regulator driver counterpart of the patch-set (it was one of the ones you Reviewed-by in the previous batch). -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog