On Sat, Jun 30, 2012 at 09:38:41AM +0530, Shilimkar, Santosh wrote:

(+ Greg, By mistake the your name got dropped cc from list)

On Fri, Jun 29, 2012 at 7:13 PM, Santosh Shilimkar
[off-list ref] wrote:

quoted

From: Aneesh V <redacted>

Device tree support for the EMIF driver.

Reviewed-by: Benoit Cousson <redacted>
Reviewed-by: Grant Likely <redacted>
Tested-by: Lokesh Vutla <redacted>
Signed-off-by: Aneesh V <redacted>
[santosh.shilimkar at ti.com: Rebased against 3.5-rc]
Signed-off-by: Santosh Shilimkar <redacted>
---
?drivers/memory/emif.c | ?291 ++++++++++++++++++++++++++++++++++++++++++++++++-
?1 file changed, 290 insertions(+), 1 deletion(-)

Wouldn't this just be better off as a separate file that only gets build
if CONFIG_OF is set, as I'm sure that other systems are going to want
access to these "read the device tree values" functions, right?

thanks,

greg k-h