Thread (23 messages) 23 messages, 5 authors, 2012-07-13

[PATCHv11 3/6] i2c: omap: Do not initialise the completion everytime

From: ABRAHAM, KISHON VIJAY <hidden>
Date: 2012-06-28 16:03:11
Also in: linux-i2c, linux-omap

Hi,

On Thu, Jun 28, 2012 at 8:41 PM, Shubhrajyoti D [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Use INIT_COMPLETION instead of init_completion in transfer.

Reviewed-by: Felipe Balbi <redacted>
Signed-off-by: Shubhrajyoti D <redacted>
---
- Add Felipe's reviewed-by tag

?drivers/i2c/busses/i2c-omap.c | ? ?3 ++-
?1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index b9915bb..6d05f18 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -490,7 +490,7 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap,
? ? ? ?w |= OMAP_I2C_BUF_RXFIF_CLR | OMAP_I2C_BUF_TXFIF_CLR;
? ? ? ?omap_i2c_write_reg(dev, OMAP_I2C_BUF_REG, w);

- ? ? ? init_completion(&dev->cmd_complete);
+ ? ? ? INIT_COMPLETION(dev->cmd_complete);
? ? ? ?dev->cmd_err = 0;

? ? ? ?w = OMAP_I2C_CON_EN | OMAP_I2C_CON_MST | OMAP_I2C_CON_STT;
@@ -999,6 +999,7 @@ omap_i2c_probe(struct platform_device *pdev)
? ? ? ?}

? ? ? ?platform_set_drvdata(pdev, dev);
+ ? ? ? init_completion(&dev->cmd_complete);
It should be INIT_COMPLETION here too.

Thanks
Kishon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help