[PATCH 1/2] ARM:MX28: Add additionnal muxing options to iMX28 DTSI

On Tue, Jun 26, 2012 at 11:02:02AM +0200, Thomas Petazzoni wrote:

Hello Shawn,

Le Mon, 25 Jun 2012 23:50:49 +0800,
Shawn Guo [off-list ref] a ?crit :

quoted

then, pinctrl system will be able to report there are 2 pin groups for
function "duart" in debugfs.

Ah nice, this explains why the mxs pinctrl driver creates a separate
group for each pinctrl DT subnode, but only creates a new function when
the name changes.

However, how would the mxs pinctrl driver handle the following case:

	pinctrl {
		duart_pins_a: duart at 0 {
			...
		}
		something_pins: something at 0 {
			...
		}
		duart_pins_b: duart at 1 {
			...
		}
	}

Reading the driver code, I have the feeling that the logic that creates
the functions will only work if the different groups for a given
function are given as consecutive subnodes in the DT. Is this correct?

That's correct.  We really need to put the pin groups for the same
function together and have then sorted in "reg" value.

-- 
Regards,
Shawn