Thread (3 messages) 3 messages, 3 authors, 2012-06-20
STALE5098d REVIEWED: 1 (0M)

[PATCH 2/2] serial: samsung: Fixed wrong comparison for baudclk_rate

From: Kukjin Kim <hidden>
Date: 2012-06-20 04:28:40
Also in: linux-samsung-soc, linux-serial

Kyoungil Kim wrote:
port->baudclk_rate should be compared to the rate of port->baudclk,
because port->baudclk_rate was assigned as the rate of port->baudclk
previously.
So to check that the current baudclk rate is same as previous rate,
the target of comparison sholud be the rate of port->baudclk.

Signed-off-by: Jun-Ho, Yoon <redacted>
Signed-off-by: Kyoungil Kim <redacted>
(Cc'ed Greg)

Acked-by: Kukjin Kim <redacted>

Greg, this is needed to fix the wrong comparison for baudclk_rate for
Samsung Serial.
Could you please pick this up in your fix tree?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
quoted hunk ↗ jump to hunk
---
 drivers/tty/serial/samsung.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 5668538..cefdd2d 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -1013,10 +1013,10 @@ static int
s3c24xx_serial_cpufreq_transition(struct notifier_block *nb,
 	 * a disturbance in the clock-rate over the change.
 	 */

-	if (IS_ERR(port->clk))
+	if (IS_ERR(port->baudclk))
 		goto exit;

-	if (port->baudclk_rate == clk_get_rate(port->clk))
+	if (port->baudclk_rate == clk_get_rate(port->baudclk))
 		goto exit;

 	if (val == CPUFREQ_PRECHANGE) {
--
1.7.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help