On Mon, 2012-06-11 at 18:04 +0800, Zhangfei Gao wrote:

+static int mmp_tdma_clear_chan_irq(struct mmp_tdma_chan *tdmac)
+{
+       u32 reg = readl(tdmac->reg_base + TDISR);
+
+       if (reg & TDISR_COMP) {
+               /* clear irq */
+               reg &= ~TDISR_COMP;
+               writel(reg, tdmac->reg_base + TDISR);
+
+               return 0;
+       }
+       return -1;
+} 

-1?
Please return a proper linux error code.


-- 
~Vinod