[PATCH] printk: Fix alignment of buf causing crash on ARM EABI

On Tue, Jun 5, 2012 at 8:59 AM, Greg KH [off-list ref] wrote:

On Tue, Jun 05, 2012 at 08:52:34AM +0200, Andrew Lunn wrote:

quoted

Commit 7ff9554bb578ba02166071d2d487b7fc7d860d62, printk: convert
byte-buffer to variable-length record buffer, causes systems using
EABI to crash very early in the boot cycle. The first entry in struct
log is a u64, which for EABI must be 8 byte aligned.

Make use of __alignof__() so the compiler to decide the alignment, but
allow it to be overridden using CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS,
for systems which can perform unaligned access and want to save
a few bytes of space.

Tested on Orion5x and Kirkwood.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
?kernel/printk.c | ? ?4 ++--
?1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, I think I have a patch in my to-apply queue that fixes this in a
bit different way. ?I'll dig that up and compare them in the next few
days as I work my way through my pending patch queue.

This patch looks good to me.

Thanks,
Kay