quoted
quoted
quoted
+ /* FIXME:
+ * - it does not work for multi-phy ehci
+ * - the best place is after debounce, but I
can't get
quoted
quoted
quoted
+ * phy there
+ */
+ if (unlikely(ehci->transceiver &&
+ (pstatus & PORT_CSC))) {
A new thought... If you move the transceiver pointer from struct
ehci_hcd to struct usb_hcd, then you _will_ be able to get at it from
within the debouncing routine.
Good suggestion, after that the driver can add PHY operation(quirk or
not)
quoted
during the whole usb host life periods.
Since it makes it more generic, I'm considering:
- change variable name from transceiver to phy
- Do we need considering phy on hub? I prefer HCD phy only.
- Do we need supporting multi-phy for one hcd? I don't know multi-phy
case, so I prefer one phy one hcd.
I suggest that you can do it at next patchset.
This patchset is just add phy notify to ehci hcd interrupt handler.
At next patchset, you can refine and improve PHY operation at the whole hcd.
I am not sure Alan's suggestion.