Thread (38 messages) 38 messages, 3 authors, 2012-06-14

[PATCH 06/17] i2c: omap: improve 1p153 errata handling

From: Shilimkar, Santosh <hidden>
Date: 2012-06-14 11:01:28
Also in: linux-i2c, linux-omap, lkml

On Thu, Jun 14, 2012 at 3:50 PM, Felipe Balbi [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Make it not depend on ISR's local variables
in order to make it easier to re-factor the
transmit data loop.

Signed-off-by: Felipe Balbi <redacted>
---
?drivers/i2c/busses/i2c-omap.c | ? 47 +++++++++++++++++++++++++++++------------
?1 file changed, 34 insertions(+), 13 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 0661ca1..52861c2 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -768,21 +768,24 @@ omap_i2c_omap1_isr(int this_irq, void *dev_id)
?* data to DATA_REG. Otherwise some data bytes can be lost while transferring
?* them from the memory to the I2C interface.
?*/
-static int errata_omap3_1p153(struct omap_i2c_dev *dev, u16 *stat, int *err)
+static int errata_omap3_1p153(struct omap_i2c_dev *dev)
?{
- ? ? ? unsigned long timeout = 10000;
+ ? ? ? unsigned long ? timeout = 10000;
Not related to this patch but this 10000 timeout magic
needs to be fixed as well.

The patch looks fine.

Regards
santosh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help