quoted

While taking care of the comments for RFC, I have introduced a
completion
that will be signalled when LA is given to the device. The driver can
wait
on that completion (wait_enum) instead of polling.

This would mean that the thread the probe is happening in will be
blocked until the LA is assigned.  That sounds like it might cause
problems, either slowing things down or worst case causing a deadlock.

I would expect that the slim_device's driver will only power-on the device
during probe (and use wait_for_completion during 1st transfer to get LA).
Typically transfers are not done as part of probe. Even if transfers need
to be done as part of probe, I expect wait_for_completion (with timeout to
avoid potential HW problems causing linux probe to wait forever) will be
better than polling for get_logical_addr.


Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.