On 2012?05?31? 15:21, bill4carson wrote:

On 2012?05?31? 14:56, Catalin Marinas wrote:

quoted

On Thu, May 31, 2012 at 06:51:22AM +0100, bill4carson wrote:

quoted

On 2012?05?31? 13:19, Catalin Marinas wrote:

quoted

On 31 May 2012 13:06, bill4carson[off-list ref]   wrote:

quoted

On 2012?05?31? 11:58, Catalin Marinas wrote:

quoted

I still didn't fully understand what the problem is. So, to make 
sure,
if you run some applications from flash using a yaffs filesystem, 
you
get random crashes. Is this correct? If yes, a solution is to 
actually
call flush_dcache_page() on the CPU that does the page copying from
flash into RAM, which could be the yaffs filesystem.

The story goes like this:
function "flush_dcache_page" should be global effective
but in ARMv6 MPCore, it was not, it was just local effective due
to hardware design.

Yes, I know this.

Then, why not fix "flush_dcache_page" to make it globally effective?

Performance?

And it's also just ARM11MPCore microarchitecture specific.

Yes, seems newer CPUs has no such limitation thus this function is 
global effective naturally. :-)

And , I find Mips's c-r4k also has this issue but it use IPI to make it. 
Details in arch/mips/mm/c-r4k.c.

 From my point of view, PREEMPT should not related to CPU type. So if 
this type of CPU does not support PREEMPT for performance reason, can we 
add something in Documentation and related Kconfig to make/mark it?

Or maybe disable task migration is also a choice. :-)

Thanks
Xiao

quoted

quoted

quoted

quoted

This may cause error in some cases for example:

1) Task running on Core-0 loading text section into memory.
    It was preempted and then migrate into Core-1;

BTW, do you have CONFIG_PREEMPT enabled?

Yes, CONFIG_PREEMPT enabled. Thus cause the task was preempted. :-)

I told you that CONFIG_PREEMPT is not supported on ARM11MPCore :).

Point!

Is it better to add comment, such as "PREEMPT is not supported for
ARM11MPCore" in somewhere(for now, I don't find such place)?
then custom will be alerted with such notice when they trying change
to PREEMPT.

And again, thanks for your patience with me :)

quoted

quoted

quoted

To be clear - is your application reading some data from flash and
trying to execute or it's the kernel doing the load via the
page/prefetch abort mechanism?

In my current case, it is yaffs root file system.

quoted

If the latter, task running on core 0 gets a prefetch abort when
trying to execute some code. The kernel reads the page from flash (via
mtd, block layer, VFS) and copies it into RAM. It can be on any CPU as
long as it calls flush_dcache_page on the same CPU that copied the
data.

No matter where the task was running or migrated to, if the code doing
the copy also called flush_dcache_page() on the same core, there is no
data left in the D-cache for that page.

Yes, I agree with it.
But how to flush the data cache on the same core with PREEMPT enabled?

That's not easily possible. But you may get better results with
VOLUNTARY_PREEMPT.

quoted

And, I think according to the design, there is no such operation that
guarantee it.

RFO/WFO tricks only work on ARM11MPCore.

quoted

But any way, I think flush_dcache_page should be global effective.
If ARMv6 MPCore didn't make it, we should try to accomplish it.

Do some performance tests first.