[RFC 08/34] dmaengine: PL08x: clean up get_signal/put_signal
From: Linus Walleij <hidden>
Date: 2012-05-31 00:53:33
From: Linus Walleij <hidden>
Date: 2012-05-31 00:53:33
On Tue, May 29, 2012 at 5:37 PM, Russell King [off-list ref] wrote:
Try to avoid dereferencing the DMA engine's channel struct in these platform helpers; instead, pass a pointer to the channel data into get_signal(), and the returned signal number to put_signal(). Signed-off-by: Russell King <redacted>
There is an in-tree user of this interface now, so it needs to be fixed as part of this patch: ]$ grep -r pl080_get_signal . ./mach-spear6xx/spear6xx.c: .get_signal = pl080_get_signal, ./plat-spear/include/plat/pl080.h:int pl080_get_signal(struct pl08x_dma_chan *ch); ./plat-spear/pl080.c:int pl080_get_signal(struct pl08x_dma_chan *ch) ./mach-spear3xx/spear3xx.c: .get_signal = pl080_get_signal, Yours, Linus Walleij