[PATCH] ARM: OMAP3/4: consolidate cpuidle Makefile
From: Daniel Lezcano <hidden>
Date: 2012-05-30 19:15:26
Also in:
linux-omap
Possibly related (same subject, not in this thread)
- 2012-05-30 · [PATCH] ARM: OMAP3/4: consolidate cpuidle Makefile · Kevin Hilman <hidden>
- 2012-05-30 · [PATCH] ARM: OMAP3/4: consolidate cpuidle Makefile · Daniel Lezcano <hidden>
- 2012-05-14 · [PATCH] ARM: OMAP3/4: consolidate cpuidle Makefile · Rajendra Nayak <hidden>
- 2012-05-10 · [PATCH] ARM: OMAP3/4: consolidate cpuidle Makefile · Daniel Lezcano <hidden>
On 05/30/2012 08:07 PM, Kevin Hilman wrote:
Daniel Lezcano [off-list ref] writes:quoted
On 05/14/2012 06:42 AM, Rajendra Nayak wrote:quoted
On Thursday 10 May 2012 03:32 PM, Daniel Lezcano wrote:quoted
The current Makefile compiles the cpuidle34xx.c and cpuidle44xx.c files even if the cpuidle option is not set in the kernel. This patch fixes this by creating a section in the Makefile where these files are compiled only if the CONFIG_CPU_IDLE option is set. This modification breaks an implicit dependency between CPU_IDLE and PM as they belong to the same block in the Makefile. This is fixed in the Kconfig by selecting explicitely PM is CPU_IDLE is set. The linux coding style recommend to use no-op functions in the headers when the subsystem is disabled instead of adding big section in C files.Looks good to me. Reviewed-by: Rajendra Nayak <redacted>Hi Kevin, I think I addressed all the points. Is it possible to consider this patch for inclusion ?Yes. I'll queue up as a cleanup for v3.6 with the reviewed-by from Rajendra.
Cool ! Thanks -- Daniel -- <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog