On 5/27/2012 8:44 PM, Artem Bityutskiy wrote:

On Sat, 2012-05-26 at 21:24 +0800, Josh Wu wrote:

quoted

use _relaxed read/write in most place. And use writel in operations of Control Register since it needs memory barrier.

Signed-off-by: Hong Xu<redacted>
Signed-off-by: Josh Wu<redacted>

This should be split on 2 or even 3 parts:

1. You move definitions and things around.
2. You separate out the init stuff into a function
3. You start using _relaxed helpers.

And you should provide better commit messages. You should explain why
you do things - just cleanup? improvement? fix? preparation for
something?

My goal here is to prepare for the PMECC support.
    Point 1 is consistent for the later PMECC patch.
    Point 2 is prepare for PMECC support.

So I think I will not add the _relaxed helpers for HW ECC operation in 
this patch series. Since that is out of the goal of this patch series.

I think this patch is too big, commit message is poor, patch does more
things than documented in the commit message.

Indeed the commit message is poor. I will fix it.

Best Regards,
Josh Wu