On Monday 21 May 2012, Linus Walleij wrote:

On Fri, May 18, 2012 at 10:39 AM, Lee Jones [off-list ref] wrote:

quoted

This patch adds a fixed regulator for use by the SMSC911x Ethernet
chip driver into the db8500 Device Tree. It also references other
regulators required by the same device.

Signed-off-by: Lee Jones <redacted>
 arch/arm/boot/dts/snowball.dts   |   13 +++++++++++++
 arch/arm/configs/u8500_defconfig |    1 +
 drivers/mfd/db8500-prcmu.c       |    1 +

We usually don't mix code and defconfig changes in the same patch.

I think it would be good if we did more often ;-)

Why can't the snowball Kconfig select the fixed regulator instead,
so you get rid of the defconfig change?

Is it a build dependency or a run-time dependency? I'd say if the
kernel fails to build without enabling the fixed regulator, it
needs to be selected in Kconfig, otherwise I'd prefer to have it
enabled in the defconfig file.

	Arnd