On Thu, 2012-05-17 at 09:37 -0700, Kevin Hilman wrote:

"Shilimkar, Santosh" [off-list ref] writes:

quoted

On Thu, May 17, 2012 at 12:34 PM, Shilimkar, Santosh
[off-list ref] wrote:

quoted

On Thu, May 17, 2012 at 4:12 AM, Kevin Hilman [off-list ref] wrote:

quoted

Tero Kristo [off-list ref] writes:

quoted

From: Rajendra Nayak <redacted>

SAR/ROM code restores only CORE DPLL to its original state
post wakeup from OFF mode.
The rest of the DPLL's in OMAP4 platform (MPU/IVA/ABE/USB/PER)
are saved and restored here during an OFF transition.

[nm at ti.com: minor cleanups]
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Rajendra Nayak <redacted>
Signed-off-by: Santosh Shilimkar <redacted>
Signed-off-by: Tero Kristo <redacted>

Some general comments:

- the register dump/print doesn't belong here.  If needed, should be a
 debug feature if needed.

- Rather than hooking into omap4_enter_lowpower(), should use
 the cluster PM enter/exit notifier chain.

This is again specific to device OFF only and not related to CPU
cluster state as such. So I don't think notifiers should be used here.

O.w even when we attempt just MPU OSWR C-state, all these functions will
get called in notifier chain.

Just a thought, we can have a separate notifier chain for device OFF. It can
allow use to get rid of 'enable_off_mode" kind of flags and can be
used by many drivers too.

Yes, I like this idea.

It allows a much cleaner collection of all the activities needed for
device off.

I can just read the device next state off in the notifier func.

-Tero