Thread (21 messages) 21 messages, 5 authors, 2012-05-21
STALE5156d

[PATCH 1/4] GPMI-NAND: Define ecc.strength

From: marex@denx.de (Marek Vasut)
Date: 2012-05-21 03:39:04

Dear Shawn Guo,
On Mon, May 21, 2012 at 04:40:09AM +0200, Marek Vasut wrote:
quoted
quoted
So you are saying the issue is introduced by gpmi-nand DT conversion?
I doubt so ...
I can be very sure that you haven't looked at the gpmi-nand DT
conversion patches at all.

The bug has been there since day one.  The commit cfbc855b (mtd: nand:
add sanity check of ecc strength to nand_scan_tail()) added a BUG() to
catch it recently.

So please at least spend some time to know the real cause before
pointing your figure to DT conversion.
Well ... since noone was really able to test the patch, noone figured out it's 
broken. We can agree on that, right.

And btw. by "I doubt so ..." I means exactly that I doubt the bug was caused by 
the DT conversion.

Best regards,
Marek Vasut
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help