Thread (45 messages) flat view 45 messages, 5 authors, 2012-05-21
STALE5215d

[PATCH 06/18] mfd: ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core

From: Linus Walleij <hidden>
Date: 2012-05-20 20:58:12

On Thu, May 17, 2012 at 3:45 PM, Lee Jones [off-list ref] wrote:
ab8500-i2c is used as core code to register the ab8500 device.
After allocating ab8500 memory, it immediately calls into
ab8500-core where the real initialisation takes place. This
patch moves all core registration and memory allocation into
the true ab8500-core file and removes ab8500-i2c completely.

Signed-off-by: Lee Jones <redacted>
---
(...)
+static int ab8500_i2c_write(struct ab8500 *ab8500, u16 addr, u8 data)
So what happened to the promised (optional as add-on) patch also
renaming these functions to ab8500_prcmu_write() etc?

The reason I insist on not ACK:in on a "promise to fix later, really
sure"-basis is exactly that these things tends to be forgotten ;-)

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help