Thread (14 messages) 14 messages, 2 authors, 2012-05-14

[PATCHv9 06/10] I2C: OMAP: Fix the crash in i2c remove

From: Shubhrajyoti <hidden>
Date: 2012-05-14 11:26:19
Also in: linux-i2c, linux-omap

On Saturday 12 May 2012 11:40 PM, Wolfram Sang wrote:
quoted
Cc: Kevin Hilman <redacted>
quoted
Cc: Rajendra Nayak <redacted>
Signed-off-by: Shubhrajyoti D <redacted>
I'd really like a comment from the PM experts if each and every driver
has to ensure that the clocks are enabled on remove like this?
Just resent cc ing linux-pm

BTW also found that

Some others are also doing the same. eg:
 
drivers/mmc/host/omap_hsmmc.c
static int __devexit omap_hsmmc_remove(struct platform_device *pdev)
{
        struct omap_hsmmc_host *host = platform_get_drvdata(pdev);
        struct resource *res;

        pm_runtime_get_sync(host->dev);
        mmc_remove_host(host->mmc);

2. drivers/usb/musb/musb_core.c

static void musb_shutdown(struct platform_device *pdev)
{
        struct musb     *musb = dev_to_musb(&pdev->dev);
        unsigned long   flags;

        pm_runtime_get_sync(musb->controller);

Anyways will wait for feedback.



quoted
quoted
---
 drivers/i2c/busses/i2c-omap.c |   
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help