Thread (1 message) 1 message, 1 author, 2012-05-07
DORMANTno replies

[PATCH v2 3/3] omap: remoteproc: add support for a boot register

From: Ohad Ben-Cohen <hidden>
Date: 2012-05-07 15:05:17
Also in: linux-omap

Hi Juan,

On Mon, May 7, 2012 at 5:38 PM, Gutierrez, Juan [off-list ref] wrote:
quoted
quoted
@@ -40,6 +41,7 @@ struct omap_rproc_pdata {
? ? ? ?const struct rproc_ops *ops;
? ? ? ?int (*device_enable) (struct platform_device *pdev);
? ? ? ?int (*device_shutdown) (struct platform_device *pdev);
+ ? ? ? u32 boot_reg;
We might want to use an IORESOURCE_MEM resource instead, since we're
dealing with a platform device anyway.

The driver can then fetch the address using platform_get_resource.
Ok, Do you mean using resource table to get the boot_reg address, right?
Sorry for the confusion - I meant using a 'struct resource' as the
standard way to pass this kind of information to platform drivers.

For example take a look how omap2_mbox_probe uses
platform_get_resource to retrieve the parameters which it then feeds
to ioremap.

Using this standard approach will probably make life easier when we
migrate to DT, too.

Thanks,
Ohad.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help