Thread (4 messages) 4 messages, 2 authors, 2012-05-04
DORMANTno replies

[PATCH 1/2] cs89x0_platform : Use ioread16/iowrite16 instead of inw/outw

From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-05-04 09:05:33
Also in: netdev

On Thursday 03 May 2012, Jaccon Bastiaansen wrote:
So if I understand you correctly you would like to have an
iopart_map() call in the cs89x0_probe() function and use the return
value of that iopart_map() call as ioaddr parameter of the
cs89x0_probe1() function. Is this correct? This would make the
cs89x0_probe() function similar to the cs89x0_platform_probe()
function where the return value of the ioremap() call is used as
ioaddr parameter of the cs89x0_probe1() function.
Correct. Currently the code relies on some platforms defining
the inw/outw functions to the same thing as readw/writew, which
is not a correct behaviour. If we change it to always use
ioread16/iowrite16, it will be correct in either case.
But why do you want to convert the current 16 bit accesses in the
#else path to 32 bit accesses? Why not using ioread16()/iowrite16()?
Sorry, typo on my side, I meant ioread16/iowrite16.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help