Thread (12 messages) flat view 12 messages, 5 authors, 2012-05-03
STALE5211d

[PATCH] gpio: Add simple poweroff-gpio driver

From: andrew@lunn.ch (Andrew Lunn)
Date: 2012-05-03 10:26:55

quoted
If you look at the Kirkwood/Orion5x, most systems that could use this
are currently not DT enabled. So i think it needs old style
platform_data as well as OF.
I wondered about this, but if you have board support code instead of
devicetree, would you have any reasons to use this driver over just
implementing the pm_power_off as most of them currently do? Seemed
to me that it was better to not complicate the code with
platform_data when it's practical use wasn't that high.
I just see that we have the same board support code repeated X
times. We can replace it with a platform device structures. We can
also add a function to create these structures, so in the end, we have
a one-liner in the board support code.

	  Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help