[PATCH v2 01/12] usb: otg: add notify_connect_change callback
From: Felipe Balbi <hidden>
Date: 2012-05-21 09:26:36
Also in:
linux-devicetree
On Mon, May 21, 2012 at 05:23:46PM +0800, Richard Zhao wrote:
quoted hunk
This let usb phy driver has a chance to change hw settings when connect status change. Signed-off-by: Richard Zhao <redacted> --- include/linux/usb/otg.h | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-)diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h index 38ab3f4..385641d 100644 --- a/include/linux/usb/otg.h +++ b/include/linux/usb/otg.h@@ -117,6 +117,10 @@ struct usb_phy { int (*set_suspend)(struct usb_phy *x, int suspend); + /* notify phy connect status change */ + int (*notify_connect_change)(struct usb_phy *x, + int port, + int connected); };@@ -252,6 +256,15 @@ usb_phy_set_suspend(struct usb_phy *x, int suspend) } static inline int +usb_phy_notify_connect_change(struct usb_phy *x, int port, int connected) +{ + if (x->notify_connect_change != NULL)
you don't need this != NULL. See that no other wrapper has it. Keep consistency. Also, this is the kind of stuff that I have been queueing for Greg so I should be in Cc. -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120521/8b2dba91/attachment-0001.sig>