On Fri, 18 May 2012 15:03:33 +0530, Thomas Abraham [off-list ref] wrote:

Add support for device based discovery.

Signed-off-by: Thomas Abraham <redacted>
Acked-by: Jaswinder Singh <redacted>

Acked-by: Grant Likely <redacted>

... but one nitpick below...

+#ifdef CONFIG_OF
+static const struct of_device_id s3c64xx_spi_dt_match[] = {
+	{ .compatible = "samsung,exynos4210-spi",
+			.data = (void *)EXYNOS4_SPI_PORT_CONFIG,

This looks completely backwards.  EXYNOS4_SPI_PORT_CONFIG casts a
pointer to a kernel_ulong_t, and this casts it right back to a
pointer.  The cast should be removed entirely from the macro, and the
platform_device_id table should have the cast from pointer to ulong.

g.