On 5/17/2012 12:02 PM, Heiko Schocher wrote:

Nori, Sekhar wrote:

quoted

On Mon, Mar 05, 2012 at 16:40:01, Heiko Schocher wrote:

quoted

quoted

+#ifdef CONFIG_OF
+static struct emac_platform_data
+	*davinci_emac_of_get_pdata(struct platform_device *pdev,
+	struct emac_priv *priv)
+{
+	struct device_node *np;
+	struct device_node *pinmux_np;
+	struct emac_platform_data *pdata = NULL;
+	const u8 *mac_addr;
+	u32 data;
+	int ret;
+	int version;
+
+	np = pdev->dev.of_node;
+	if (!np)
+		goto nodata;
+	else
+		version = EMAC_VERSION_2;

You could set pdata->version directly here. 

done.

Just noticed that pdata is not setup at this time. I guess you will be
moving around some code to do this.

quoted

quoted

+
+	pinmux_np = of_parse_phandle(np, "pinmux-handle", 0);
+	if (pinmux_np)
+		davinci_cfg_reg_of(pinmux_np);

This is a DaVinci specific pinmux function and this
driver can be used in non-DaVinci platforms like C6x
and OMAP. So, it will not be correct to call a DaVinci
specific function here.

Ah, right!

quoted

Can you drop the pinmux from this patch for now? On DaVinci,

Done ... Hmm.. so I think, I should drop this for all patches
from my patchset, right?

Yes.

quoted

for pinmux, we need to migrate to drivers/pinctrl/ as well.

Ah, I see ... take a look at it, maybe I find time to do here
something ... or do you know about work in progress here?

There is no work in progress within TI. So, if you are interested in
taking a stab it it, it will be great.

quoted

Doing this will also make this patch independent of the rest
of this series can even be merged separately. Can you please
make these changes and resend just this patch?

Yep, I do some test with the changes you requested and resend
this patch ... do you prefer some tree, which I should use as
base?

This one should ideally merge through the network subsystem so may be
base it on the net-next tree?

http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=summary

Thanks,
Sekhar