Thread (1 message) 1 message, 1 author, 2012-05-05

[PATCH v2 2/5] dma: mxs-dma: make platform_device_id more generic

From: marex@denx.de (Marek Vasut)
Date: 2012-05-05 14:32:14
Also in: linux-devicetree

Dear Shawn Guo,
On 5 May 2012 21:12, Marek Vasut [off-list ref] wrote:
quoted
Can't the patches be reordered then to avoid adding this altogether?
Maybe.  But I do not think it's really worth the effort.
quoted
You don't have to add dead code in this patch and re-add it when needed.
Or fix the macro to take the parameter then, though I don't understand
why you'd want to take it and then hide it.
I do not completely understand the comment.  My point is the problem
is in the existing code.  It's not introduced by Dong's patch.  The
problem should be fixed in another patch, and we do not want to do
several things in one patch.
Then order such a patch before Dong's series then? It'd all be clear, without 
compromises.
Regards,
Shawn
Best regards,
Marek Vasut
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help