[PATCH] Drop superfluous setting of i2c_board_info.type
From: Uwe Kleine-König <hidden>
Date: 2012-05-24 16:22:52
Also in:
linux-sh, lkml
On Thu, May 24, 2012 at 04:38:23PM +0200, Paul Bolle wrote:
Three instances of struct i2c_board_info have their "type" member set to "tsc2007" twice. First through the I2C_BOARD_INFO macro and then directly. Drop the superfluous second setting. Signed-off-by: Paul Bolle <redacted> --- 0) Entirely untested. I'm unsure what toolchain(s) is (are) needed to compile this and I am certain that I don't have the hardware. 1) This is apparently legal. Doesn't gcc issue a warning for this?
I wondered about that too, gcc doesn't even warn when the two values are different. See for example commit bd9e310dca15c9987256f67af19f9f42426e7493.
arch/arm/mach-imx/mach-cpuimx35.c | 1 - arch/arm/mach-imx/mach-cpuimx51sd.c | 1 -
I already submitted a patch for the imx bits with Message id 1335989287-10094-1-git-send-email-u.kleine-koenig at pengutronix.de. (e.g. http://mid.gmane.org/1335989287-10094-1-git-send-email-u.kleine-koenig at pengutronix.de) Don't know if Sascha took it already. If he did, he didn't tell me. Best regards Uwe
quoted hunk ↗ jump to hunk
arch/arm/mach-shmobile/board-ap4evb.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-)diff --git a/arch/arm/mach-imx/mach-cpuimx35.c b/arch/arm/mach-imx/mach-cpuimx35.c index 8ecc872..b1a4796 100644 --- a/arch/arm/mach-imx/mach-cpuimx35.c +++ b/arch/arm/mach-imx/mach-cpuimx35.c@@ -70,7 +70,6 @@ static struct i2c_board_info eukrea_cpuimx35_i2c_devices[] = { I2C_BOARD_INFO("pcf8563", 0x51), }, { I2C_BOARD_INFO("tsc2007", 0x48), - .type = "tsc2007", .platform_data = &tsc2007_info, .irq = IMX_GPIO_TO_IRQ(TSC2007_IRQGPIO), },diff --git a/arch/arm/mach-imx/mach-cpuimx51sd.c b/arch/arm/mach-imx/mach-cpuimx51sd.c index 9fbe923..89eb93c 100644 --- a/arch/arm/mach-imx/mach-cpuimx51sd.c +++ b/arch/arm/mach-imx/mach-cpuimx51sd.c@@ -124,7 +124,6 @@ static struct i2c_board_info eukrea_cpuimx51sd_i2c_devices[] = { I2C_BOARD_INFO("pcf8563", 0x51), }, { I2C_BOARD_INFO("tsc2007", 0x49), - .type = "tsc2007", .platform_data = &tsc2007_info, .irq = IMX_GPIO_TO_IRQ(TSC2007_IRQGPIO), },diff --git a/arch/arm/mach-shmobile/board-ap4evb.c b/arch/arm/mach-shmobile/board-ap4evb.c index b56dde2..801de4b 100644 --- a/arch/arm/mach-shmobile/board-ap4evb.c +++ b/arch/arm/mach-shmobile/board-ap4evb.c@@ -1168,7 +1168,6 @@ static struct tsc2007_platform_data tsc2007_info = { static struct i2c_board_info tsc_device = { I2C_BOARD_INFO("tsc2007", 0x48), - .type = "tsc2007", .platform_data = &tsc2007_info, /*.irq is selected on ap4evb_init */ };-- 1.7.7.6
-- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |