On 05/04/2012 12:33 AM, Hiroshi Doyu wrote:

Stephen Warren wrote at Thu, 3 May 2012 19:48:25 +0200:

quoted

On 05/03/2012 10:05 AM, Hiroshi DOYU wrote:

quoted

Use "tegra_ahb_enable_smmu()" to inform AHB that SMMU is
ready, instead of directly aceessing AHB registers.

...

quoted

quoted

@@ -911,14 +899,16 @@ static int tegra_smmu_probe(struct platform_device *pdev)

quoted

+	smmu->ahb = of_parse_phandle(pdev->dev.of_node, "ahb", 0);

Hmm, "ahb" should probably be "nvidia,ahb".

Does this mean the following in dts?

	ahb: ahb at 6000c004 {
		compatible = "nvidia,tegra30-ahb";
		reg = <0x6000c004 0x14c>; /* AHB Arbitration + Gizmo Controller */
	};

	smmu: smmu at 7000f000 {
		nvidia,ahb = &ahb;
	};      ^^^^^^^^^^

Yes.