Thread (18 messages) flat view 18 messages, 3 authors, 2012-05-03

[PATCH v2 1/3] ARM: imx: Add common imx cpuidle init functionality.

From: Rob Lee <hidden>
Date: 2012-05-02 14:09:34
Also in: lkml

On Wed, May 2, 2012 at 9:07 AM, Shawn Guo [off-list ref] wrote:
On 2 May 2012 21:59, Rob Lee [off-list ref] wrote:
quoted
quoted
quoted
+ ? ? ? ? ? ? ret = cpuidle_register_device(dev);
+ ? ? ? ? ? ? if (ret) {
+ ? ? ? ? ? ? ? ? ? ? pr_err("%s: Failed to register cpu %u\n",
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? __func__, cpu_id);
Nit: print ret (error code) too?
I added the printing of the error code based on Sascha's suggestion in
v1 of this submission.
But you did not print "ret" in above pr_err.
Argh, sorry, still trying to wake up I guess.  Thanks.
Regards,
Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help